Skip to content

Fixes: #15408 - Add primary_ip4 and primary_ip6 to bulk import form for VDC #17509

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Sep 19, 2024

Conversation

bctiemann
Copy link
Contributor

@bctiemann bctiemann commented Sep 16, 2024

Fixes: #15408

Adds primary_ip4 and primary_ip6 to VirtualDeviceContextImportForm.

Uses address as the accessor field.

Screenshot 2024-09-16 at 2 49 04 PM

Copy link
Member

@jeremystretch jeremystretch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The querysets for primary_ip4 and primary_ip6 need to be limited to IP addresses assigned to an interface on the specified device.

@bctiemann
Copy link
Contributor Author

Added queryset filtering.

@bctiemann bctiemann self-assigned this Sep 17, 2024
@jeremystretch jeremystretch merged commit 2dd5c82 into develop Sep 19, 2024
6 checks passed
@jeremystretch jeremystretch deleted the 15408-ip4-ip6-bulk-import-vdc branch September 19, 2024 17:51
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add primary_ip4/primary_ip6 fields to virtual-device-context bulk import
3 participants