Skip to content

17460 make ModuleType / DeviceType bulk buttons consistent #17463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Oct 28, 2024

Conversation

arthanson
Copy link
Collaborator

Fixes: #17460

Button ordering / placement and naming are consistent with rest of app:

devicetype
moduletype

@arthanson arthanson changed the title DRAFT: 17460 make ModuleType / DeviceType bulk buttons consistent 17460 make ModuleType / DeviceType bulk buttons consistent Sep 17, 2024
@arthanson
Copy link
Collaborator Author

For review - please do a sanity check on the DeviceType / ModuleType bulk buttons, I went through but good to get another set of eyes to make sure I didn't miss as I originally had moved the pathing wrong.

@arthanson arthanson marked this pull request as ready for review September 24, 2024 22:00
Copy link
Contributor

This PR has been automatically marked as stale because it has not had recent activity. It will be closed automatically if no further action is taken.

@github-actions github-actions bot added the pending closure Requires immediate attention to avoid being closed for inactivity label Oct 25, 2024
@jeremystretch jeremystretch merged commit 476194f into develop Oct 28, 2024
6 checks passed
@jeremystretch jeremystretch deleted the 17460-module-bay-buttons branch October 28, 2024 19:04
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pending closure Requires immediate attention to avoid being closed for inactivity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DeviceType ModuleBays has extraneous Add button at bottom
3 participants