Hide exception in ObjectCountsWidget for models without a xxx_list view function
#17342
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
candlerb
force-pushed
the
candlerb/17341
branch
from
6eaeca9 to
70baeb9
Compare
bctiemann
approved these changes
Sep 3, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #17341
This is a quick workaround specifically to stop ObjectCountsWidget raising an exception for models without a
xxx_listview function.(A better, more generally useful solution would be to catch exceptions raised by any widget, and allow the widget pane to be displayed with an error message. That would avoid Netbox becoming unusable for any widget problem, and would also allow the widget settings to be edited to correct the problem)