Closes #16964: Validate password when creating a new user or updating password for an existing user

[nishant131]

Fixes: #16964

• Call validate_password() on the configured password validators, while cleaning the UserForm data.

[jeremystretch]

Hi @nishant131, thanks for digging into this! In addition to the form validation, we also need to enforce the validation under the REST serializer for the User model.

I went ahead and did this (and added the relevant tests), but when I pushed my commit it ended up creating a new branch under the netbox repo. I'm not sure what happened. 😕

I've opened PR #16990, which includes your initial commit, to replace this. Sorry for the mix-up.

[nishant131]

Hi @jeremystretch, I think the new branch got created on netbox repo as I had unchecked Allow edits by maintainers in the PR. Since, it was my first contribution to netbox, I wasn't sure whether to allow it or not 😕.
Maybe, we can add this in the PR submission guideline doc.

Thank you for adding the validation under the REST serializer, I'll incorporate that in my setup as well 🙂

[jeremystretch]

I think the new branch got created on netbox repo as I had unchecked Allow edits by maintainers in the PR

That's my suspicion as well, however in the past GitHub has rejected the push in such cases. Maybe they've changed things. 🤷‍♂️