Skip to content

Fixes #16760: datasource git on local file system fails #16872

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 10, 2024
Merged

Fixes #16760: datasource git on local file system fails #16872

merged 3 commits into from
Jul 10, 2024

Conversation

thefriendlynet
Copy link
Contributor

Fixes: #16760

Datasource git on local file system fails with SyncError("Fetching remote data failed (TypeError): LocalGitClient.init() got an unexpected keyword argument 'quiet'")

jeremystretch
jeremystretch approved these changes Jul 10, 2024
View reviewed changes
Copy link
Member

@jeremystretch jeremystretch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking this on @thefriendlynet! I've just tweaked your fix to only add the quiet & depth arguments if using a remote URL (rather than removing them if not).

@thefriendlynet
Copy link
Contributor Author

Thanks for taking this on @thefriendlynet! I've just tweaked your fix to only add the quiet & depth arguments if using a remote URL (rather than removing them if not).

Perfect, I wasn't quite sure about the proper direction for the fix, hence my question in the issue.
Thanks for taking the time to review the PR.
I guess there aren't many other URL schemes anyway besides http(s) and local

@jeremystretch jeremystretch merged commit f2e1de0 into netbox-community:develop Jul 10, 2024
3 checks passed
jeremystretch added a commit that referenced this pull request Jul 26, 2024
@thefriendlynet @jeremystretch
Fixes #16760: datasource git on local file system fails (#16872)
0e0d617 
* Fixes #16760: datasource git on local file system fails

* Fixes #16760: datasource git on local file system fails

* Set depth & quiet parameters only if using a remote URL

---------

Co-authored-by: Jeremy Stretch <jstretch@netboxlabs.com>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jeremystretch jeremystretch jeremystretch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Datasource git on local file system fails
2 participants
@thefriendlynet @jeremystretch