Fixes #14829 Simple condition (without and/or) does not work in event rule #14870
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ical operator. Added some tests.
jeremystretch
requested changes
Jan 22, 2024
|
This PR has been automatically marked as stale because it has not had recent activity. It will be closed automatically if no further action is taken. |
github-actions
bot
added
the
pending closure
jeremystretch
removed
the
pending closure
|
@Julio-Oliveira-Encora would you mind tackling the merge conflicts here? It should just be changes from enabling translation of the error messages. |
Done! |
|
@arthanson you're free to review this & merge as you see fit. |
arthanson
requested changes
May 29, 2024
…s_not_work_in_event_rule
arthanson
requested changes
May 30, 2024
…s_not_work_in_event_rule
arthanson
approved these changes
Jun 7, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #14829
This change allows the addition of simple conditions in the Event Rule. Currently, it only allows to add conditions with logical operators.