Changing an existing device in a rack that will "bump" into another device doesn't error

[ckdarby]

Deployment Type

NetBox Cloud (Used the Netbox demo)

NetBox Version

v4.3.1

Python Version

3.10

Steps to Reproduce

1. Have a rack
2. Put a device above
3. Create a 1U device below
4. Try to change 1U device to 2U device

No error is presented even though save button allows action to happen.

Example, modify optical patch from 1u to 2u device:

Expected Behavior

Expected the 2U to take up the available space below OR to communicate to the user this action isn't possible.

Observed Behavior

No error is presented and just left on the save form.

[arthanson]

@ckdarby where are you modifying the height (what menu items are you going to)? I'm not seeing this, I added a device as you said in step 1-3 with a device-type that had a 1U size, then I go to the device type and change it to 2U and I do get an error (see below). Or are you trying to edit it somewhere else? This is NetBox v4.3.1

[ckdarby]

From this edit button

[ckdarby]

I should have clarified that I am not modifying the device itself but changing the device type from 1U to 2U.

In that edit page I am changing the type from APC Optical Patch Panel 8 type in the edit to 48-patch panel (2U).

[arthanson]

@ckdarby I am still not seeing that, I used a device with a device type with 1U in the rack, I then edit the device and change it to a device type with a 2U and I get an error:

[ckdarby]

@arthanson Confirmed on my side. This would likely be more of an enhancement than a bug at this point.

As a new user, this is what I see when I change the type and click save

There’s no user feedback indicating an error on the modified field. When I return to the page, my change to '48-Port Patch Panel' still appears, so it’s not immediately clear anything went wrong. The error only becomes visible when I scroll down to an unrelated field I didn't modify, which could be confusing and counterintuitive for users.

This leads to some discussions:

• Should errors be displayed at the top combined given?
• Should clicking save with a failure not return to the prior state?
• Should modifying the device still not simply shift the unit space down, as it is available?