Skip to content

Conversation

@MaIT-HgA
Copy link
Contributor

@MaIT-HgA MaIT-HgA commented Sep 30, 2024

Changes:

  • adding Finalizers are moved up
  • IP/Prefix deletion functions are updated with not found errors
  • error handling in Finalizers is updated with not found errors
  • integration test is updated

Close #77

@MaIT-HgA MaIT-HgA force-pushed the fix/finalizers branch 3 times, most recently from 9b2fc00 to a1f57ac Compare September 30, 2024 11:37
@MaIT-HgA MaIT-HgA self-assigned this Sep 30, 2024
@MaIT-HgA MaIT-HgA added the bug Something isn't working label Sep 30, 2024
@MaIT-HgA MaIT-HgA marked this pull request as ready for review September 30, 2024 12:02
@henrybear327 henrybear327 removed their request for review October 1, 2024 07:49
@MaIT-HgA MaIT-HgA force-pushed the fix/finalizers branch 2 times, most recently from 6786ac5 to b3b971a Compare October 7, 2024 12:50
@MaIT-HgA MaIT-HgA force-pushed the fix/finalizers branch 2 times, most recently from 7c9743a to 5f41060 Compare October 8, 2024 06:34
@MaIT-HgA MaIT-HgA force-pushed the fix/finalizers branch 2 times, most recently from 7c1c8e6 to 77b6314 Compare October 8, 2024 06:54
@MaIT-HgA MaIT-HgA merged commit 064e6b5 into main Oct 8, 2024
5 checks passed
@MaIT-HgA MaIT-HgA deleted the fix/finalizers branch October 8, 2024 08:03
vaishutin pushed a commit to vaishutin/netbox-operator that referenced this pull request Aug 17, 2025
* add check for tenant existence

* update deletion for finalizers and move finalizer creation up

* update deletion for finalizers and move finalizer creation up

* integration tests are updated

---------

Co-authored-by: Hoanganh.Mai <hoanganh.mai@swisscom.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Finalizer set too late

4 participants