-
Notifications
You must be signed in to change notification settings - Fork 12
start release pipeline on workflow_dispatch #436
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was doing this from my phone apologies if I didn’t see some reference
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The sample release in your fork looks good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the suggestions. I cleaned up some parts of the script based on the comments and tested it in the forked repo.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
So far the image version and change log were only created after the release was published, so the tag in the release note didn't point to the commit in which the image version is bumped.
With the new manually triggered workflow the new version and a release summary can be used as parameters to create a new release where the tag points to the commit in which the image is bumped.
This PR is based on the proposal of @alexandernorth and @pablogarciamiranda.
Tested in this fork: https://github.com/bruelea/netbox-operator
Fixed netbox deployment in e2e tests by using bitnamilegacy image repository