-
Notifications
You must be signed in to change notification settings - Fork 12
Adding automatic release workflow #390
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks @pablogarciamiranda Something that came to mind just now. I understand this will lead to the following commits:
I think it would be great if the commit that has the tag attached matches with the tag used in
|
|
Hey @jstudler , Thanks for the suggestions! After thinking a bit into both options...
What do you think @bruelea @henrybear327 @alexandernorth @faebr Any preferences? |
We had a short discussion with @jstudler last week and decided that the current implementation is fine. It seems to be common practice to have the tag pointing to the mr and then the kustomization being updated only in the later step. I believe this makes sense since then the actual changes are also in the commit which is tagged. |
|
@pablogarciamiranda can we allign the auto-generated release note sections to be the same as the ones we already have? |
I would also agree with this approach, that way the tag points to the actual code changes |
@faebr After having tested and investigated a bit... GitHub's auto-generated release notes always render categories as H3 under "What's Changed", not as separate H2 sections like our current format. I see the next options
|
…ion for the image in the kustomization.yaml
I think it makes sense to keep the github format. It is probably used in most repo's. Then we can adapt our current ones, you are right its not that many |
Co-authored-by: Fabian <30692464+faebr@users.noreply.github.com>
* Adding automatic release workflow * test: add temporary branch trigger for testing release workflow * Adding gh release notes configuration * Fix linting * Fix linting * fix: organize release notes sections without duplication * fix: prevent duplicate What's Changed section in release notes * fix: use simpler release notes configuration * Simplifying bump-version.sh and release.yaml by having already a section for the image in the kustomization.yaml * Adding new line to the end of the file * feat: add release note categories for better organization * Simplify use only Version Bumps category for release notes * test: add test file to verify release notes categories * fix: remove emoji from Version Bumps title for consistency * remove test file and prepare for merge * Update config/manager/kustomization.yaml Co-authored-by: Fabian <30692464+faebr@users.noreply.github.com> --------- Co-authored-by: Pablo Garcia Miranda <pablo.garciamiranda@swisscom.com> Co-authored-by: Fabian <30692464+faebr@users.noreply.github.com>
Automates the version bumping process when creating releases.
When you push a tag, GitHub Actions will:
config/manager/kustomization.yamlwith the new versionHow to release after this PR
Everything else is automated.
Test Release
This workflow has created automatically https://github.com/netbox-community/netbox-operator/releases/tag/v0.2.5-test
It has run as expected (created release and version bump commit):
https://github.com/netbox-community/netbox-operator/actions/runs/16464848339/job/46539652934?pr=390
But couldn't push to main because it ran from a feature branch.
This will work correctly once merged.
### After code review
Once the code review is done, I will remove the section that was used for testing and preventing the workflow to pass.