-
Couldn't load subscription status.
- Fork 12
Add formatting configurations and yamllint action #376
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 5fa43ec.
bruelea
reviewed
Jul 17, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! There are some warnings in the yamllint step. Do you want to resolve them before merging?
bruelea
approved these changes
Jul 18, 2025
vaishutin
pushed a commit
to vaishutin/netbox-operator
that referenced
this pull request
Aug 17, 2025
Adds a pipeline step to ensure kustomization and yaml validity before merging. Also adds configurations for yamlfmt and pre-commit to ease formatting for users. Changes: * lint-yaml job that executes `yamllint` for all directories except the CRDs that are autogenerated by kubebuilder. * `.yamllint` file for configuration of [yamllint](https://github.com/adrienverge/yamllint) * `.yamlfmt` file for configuration of [yamlfmt](https://github.com/google/yamlfmt) * `.pre-commit-config.yaml` file for configuration of [pre-commit](https://pre-commit.com/)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a pipeline step to ensure kustomization and yaml validity before merging. Also adds configurations for yamlfmt and pre-commit to ease formatting for users. Changes:
yamllintfor all directories except the CRDs that are autogenerated by kubebuilder..yamllintfile for configuration of yamllint.yamlfmtfile for configuration of yamlfmt.pre-commit-config.yamlfile for configuration of pre-commit