Skip to content

Conversation

@jstudler
Copy link
Collaborator

@jstudler jstudler commented Jul 17, 2025

Adds a pipeline step to ensure kustomization and yaml validity before merging. Also adds configurations for yamlfmt and pre-commit to ease formatting for users. Changes:

  • lint-yaml job that executes yamllint for all directories except the CRDs that are autogenerated by kubebuilder.
  • .yamllint file for configuration of yamllint
  • .yamlfmt file for configuration of yamlfmt
  • .pre-commit-config.yaml file for configuration of pre-commit

@jstudler jstudler self-assigned this Jul 17, 2025
@jstudler jstudler requested review from bruelea and faebr July 17, 2025 11:14
Copy link
Collaborator

@bruelea bruelea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! There are some warnings in the yamllint step. Do you want to resolve them before merging?

@jstudler jstudler requested a review from bruelea July 18, 2025 08:12
@jstudler jstudler merged commit cdb8317 into main Jul 18, 2025
13 checks passed
@jstudler jstudler deleted the feature/fmt-lint branch July 18, 2025 13:06
vaishutin pushed a commit to vaishutin/netbox-operator that referenced this pull request Aug 17, 2025
Adds a pipeline step to ensure kustomization and yaml validity before merging. Also adds configurations for yamlfmt and pre-commit to ease formatting for users. Changes:

* lint-yaml job that executes `yamllint` for all directories except the CRDs that are autogenerated by kubebuilder.
* `.yamllint` file for configuration of [yamllint](https://github.com/adrienverge/yamllint)
* `.yamlfmt` file for configuration of [yamlfmt](https://github.com/google/yamlfmt)
* `.pre-commit-config.yaml` file for configuration of [pre-commit](https://pre-commit.com/)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants