Add ownerReference to child resource on update #369
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bruelea
requested changes
Jul 14, 2025
tests/e2e/Prefix/IPv4/prefixclaim-ipv4-update-ownerreference/netbox_v1_prefix_1.yaml
Outdated
Show resolved
Hide resolved
…etbox_v1_prefix_1.yaml Fix netboxOperatorRestorationHash Co-authored-by: bruelea <166021996+bruelea@users.noreply.github.com>
bruelea
approved these changes
Jul 15, 2025
jstudler
deleted the
feature/add-ownerreference-to-child-resource-on-update
branch
vaishutin
pushed a commit
to vaishutin/netbox-operator
that referenced
this pull request
Aug 17, 2025
A gap discovered in a backup and restore test was that the NetBox Operator child resources do not get the ownerReference set on Update. The goal of this PR is to make sure the IpAddressClaim, PrefixClaim and IpRangeClaim controllers add the ownerReference to the IpAddress, Prefix and IpRange CR when it reconciles/updates them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A gap discovered in the backup and restore test was that the NetBox Operator child resources do not get the ownerReference set on Update. The goal of this PR is to make sure the IpAddressClaim, PrefixClaim and IpRangeClaim controllers add the ownerReference to the IpAddress, Prefix and IpRange CR when it reconciles/updates them.