Feature/check keys in parent prefix selector #295
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
faebr
requested changes
May 6, 2025
Co-authored-by: Fabian <30692464+faebr@users.noreply.github.com>
faebr
approved these changes
May 6, 2025
faebr
reviewed
May 6, 2025
tests/e2e/Prefix/IPv4/prefixclaim-ipv4-invalid-parentprefixselector/chainsaw-test.yaml
Outdated
Show resolved
Hide resolved
faebr
approved these changes
May 6, 2025
vaishutin
pushed a commit
to vaishutin/netbox-operator
that referenced
this pull request
Aug 17, 2025
* check if custom fields in parent prefix selector exist * add unit tests * add chainsaw test --------- Co-authored-by: Fabian <30692464+faebr@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this feature a check is added to only allow existing fields in the parentPrefixSelector.
If the parent prefix selector contains a key for a custom field that does not exist in NetBox, the key is ignored in the filter.