Consolidate Status and Condition reporting #265
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bruelea
reviewed
Mar 14, 2025
faebr
requested changes
Apr 7, 2025
adjust string separator add copyright header modified error return for prefixclaimcontroller implement feedback - logging message location only perform update call if the condition changed
alexandernorth
force-pushed
the
feature/conditions-improvements
branch
from
6e8e185 to
ea07072
Compare
alexandernorth
force-pushed
the
feature/conditions-improvements
branch
from
06ac2a7 to
a454dde
Compare
bruelea
requested changes
Apr 17, 2025
bruelea
approved these changes
Apr 22, 2025
faebr
approved these changes
Apr 22, 2025
vaishutin
pushed a commit
to vaishutin/netbox-operator
that referenced
this pull request
Aug 17, 2025
* refactor event/status reporting * only perform update call if the condition changed * don't use private fields of EventStatusRecorder * set ready false at beginning of reconcile loop * add information about kind image loading with containerd * fix match string for chainsaw tests * change format string to wrap error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR shows one way in which we can consolidate the reporting of status and conditions into a common function.
It exposes access to the EventRecorder so events can be emitted independently of condition updates, and also logs changes in conditions as well as errors.
Would be happy to receive feedback and take suggestions as to how we can improve this functionality.