Remove duplicate kind cluster creation #257
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
henrybear327
force-pushed
the
ci/remove-duplicate-kind-creation
branch
from
d707016 to
bcfb28a
Compare
|
If the test can pass, we can indeed remove those setup parts :) |
henrybear327
approved these changes
Mar 10, 2025
vaishutin
pushed a commit
to vaishutin/netbox-operator
that referenced
this pull request
Aug 17, 2025
Kind clusters for the e2e tests are implicitly created in the make test-e2e-* targets that are triggered in the Run e2e tests steps of the e2e-tests pipeline. Thus, there is no need for the additional Start kind cluster step in the e2e tests pipeline. This PR removes the additional kind cluster creation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kind clusters for the e2e tests are implicitly created in the
make test-e2e-*targets that are triggered in theRun e2e testssteps of thee2e-testspipeline. Thus, there is no need for the additionalStart kind clusterstep in the e2e tests pipeline. This PR removes the additional kind cluster creation.