Skip to content

Add metrics for rest requests towards netbox #231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 20, 2025
Merged

Add metrics for rest requests towards netbox #231

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 21 additions & 2 deletions pkg/netbox/api/client.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,10 +17,12 @@ limitations under the License.
package api

import (
"context"
"crypto/tls"
"crypto/x509"
"fmt"
"net/http"
"strconv"
"time"

httptransport "github.com/go-openapi/runtime/client"
Expand All @@ -30,6 +32,7 @@ import (

"github.com/netbox-community/go-netbox/v3/netbox/client/extras"
"github.com/netbox-community/netbox-operator/pkg/netbox/interfaces"
"k8s.io/client-go/tools/metrics"
)

const (
Expand Down Expand Up @@ -64,6 +67,20 @@ func (r *NetboxClient) VerifyNetboxConfiguration() error {
return nil
}

type InstrumentedRoundTripper struct {
Transport http.RoundTripper
}

func (irt *InstrumentedRoundTripper) RoundTrip(req *http.Request) (*http.Response, error) {
resp, err := irt.Transport.RoundTrip(req)
if err != nil {
return nil, err
}

metrics.RequestResult.Increment(context.TODO(), strconv.Itoa(resp.StatusCode), req.Method, req.Host)
return resp, nil
}

func GetNetboxClient() (*NetboxClient, error) {

logger := log.StandardLogger()
Expand Down Expand Up @@ -92,8 +109,10 @@ func GetNetboxClient() (*NetboxClient, error) {
}

httpClient := &http.Client{
Transport: &http.Transport{
TLSClientConfig: tlsConfig,
Transport: &InstrumentedRoundTripper{
Transport: &http.Transport{
TLSClientConfig: tlsConfig,
},
},
Timeout: time.Second * time.Duration(RequestTimeout),
}
Expand Down