Skip to content

Conversation

@faebr
Copy link
Collaborator

@faebr faebr commented Jan 14, 2025

No description provided.

@faebr faebr requested a review from bruelea January 14, 2025 18:31
Copy link
Collaborator

@bruelea bruelea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! Only noticed, that some labels got relevant for matching the metrics service only to the netbox-operator pod got removed.

@faebr faebr merged commit 40b001d into main Jan 20, 2025
8 checks passed
@faebr faebr deleted the feature/upgrade-kubebuilder branch January 20, 2025 16:02
vaishutin pushed a commit to vaishutin/netbox-operator that referenced this pull request Aug 17, 2025
…netbox-community#205)

* upgraded controller tools and removed rbac-proxy for metrics endpoint

* added part-of labels for metrics monitoring

* added part-of labels for serviceMonitor matchlabels selector
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants