Support reservation of IpRanges #130
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bruelea
force-pushed
the
feat/support-reservation-of-ipranges
branch
2 times, most recently
from
6dd0a08 to
549e32a
Compare
bruelea
force-pushed
the
feat/support-reservation-of-ipranges
branch
from
549e32a to
ff7f155
Compare
henrybear327
requested changes
Nov 25, 2024
bruelea
force-pushed
the
feat/support-reservation-of-ipranges
branch
2 times, most recently
from
a58fc71 to
16ae6db
Compare
alexandernorth
requested changes
Nov 26, 2024
|
Good work @bruelea :) |
bruelea
force-pushed
the
feat/support-reservation-of-ipranges
branch
from
7f5720b to
5a96faa
Compare
bruelea
force-pushed
the
feat/support-reservation-of-ipranges
branch
from
5a96faa to
87bdd6c
Compare
bruelea
force-pushed
the
feat/support-reservation-of-ipranges
branch
from
df836d6 to
9c96d13
Compare
|
LGTM! When CI pipelines are fixed and the comments are all resolved, I will approve it ;) Good job @bruelea |
bruelea
force-pushed
the
feat/support-reservation-of-ipranges
branch
from
9c96d13 to
19bdf4f
Compare
|
Please create a tracking GitHub issue for the IPRange Testing :) |
bruelea
force-pushed
the
feat/support-reservation-of-ipranges
branch
from
19bdf4f to
afc40a6
Compare
alexandernorth
approved these changes
Nov 29, 2024
henrybear327
approved these changes
Nov 29, 2024
jstudler
reviewed
Nov 29, 2024
Co-authored-by: Alexander North <alexandernorth@users.noreply.github.com>
Co-authored-by: Chun-Hung Tseng <henrybear327@users.noreply.github.com>
Co-authored-by: Chun-Hung Tseng <henrybear327@users.noreply.github.com>
bruelea
force-pushed
the
feat/support-reservation-of-ipranges
branch
from
a06e20d to
fd94329
Compare
jstudler
approved these changes
Dec 3, 2024
Closed
vaishutin
pushed a commit
to vaishutin/netbox-operator
that referenced
this pull request
Aug 17, 2025
* add IpRange and IpRangeClaim apis * implement controllers * refactor controller * add unit tests * use availabe ips in range to create list for status * refactor iprange recondile funcitons * fix error handling * fix linting * set minimum size of irc to 2 * Apply suggestions from code review Co-authored-by: Alexander North <alexandernorth@users.noreply.github.com> * Apply suggestions from code review Co-authored-by: Chun-Hung Tseng <henrybear327@users.noreply.github.com> * Apply suggestions from code review Co-authored-by: Chun-Hung Tseng <henrybear327@users.noreply.github.com> * improvements based on review * improvements for review * rename generateManagedCustomFieldsAnnotation funciton * limit size of iprangeclaim CR to 50 * improve description of iprangeclaim.spec.size field --------- Co-authored-by: Alexander North <alexandernorth@users.noreply.github.com> Co-authored-by: Chun-Hung Tseng <henrybear327@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #137