Skip to content

Conversation

@Wellyas
Copy link
Contributor

@Wellyas Wellyas commented Nov 2, 2022

Related Issue: None

New Behavior

Extends requirements to enable the use of SAML SSO Providers from Python Social Auth.

Contrast to Current Behavior

Currently these dependencies aren't included, meaning users can't take advantage of SAMLSSO unless they create their own image.

Discussion: Benefits and Drawbacks

  • Benefit: Enabling users to use functionality included in Netbox without needing to create bespoke images and SAML is more use than OICD in the enterprise world.
  • Drawback: Additional dependencies increase the image size, and the version pinning will need to be periodically reviewed. The build of the image will take more time because of the need to build python3-saml and the cryptography python package.
  • Backwards-compatible: Yes

Changes to the Wiki

None

Proposed Release Note Entry

Requirements needed to use SAML SSO Providers have been added

Double Check

  • I have read the comments and followed the PR template.
  • I have explained my PR according to the information in the comments.
  • My PR targets the develop branch.

@tobiasge tobiasge enabled auto-merge November 11, 2022 12:08
@tobiasge tobiasge merged commit 0cac6f5 into netbox-community:develop Nov 11, 2022
@Wellyas Wellyas deleted the patch-1 branch November 12, 2022 09:07
@tobiasge tobiasge mentioned this pull request Dec 15, 2022
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants