feat: allow the worker and housekeeping to mount the media PVC readOnly #401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rcrawf
reviewed
Oct 30, 2024
rcrawf
approved these changes
Oct 30, 2024
It wasn't specifically, but it miiiight help with that? Since the worker's mounting that stuff read-only, it might let it pass without needing a RWX-capable volume. |
|
Just thought about it: the schema should probably be updated as well. Edit: you did it in the meantime, so all good👌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR lets you mount things readOnly on the worker and housekeeping so you don't need
ReadWriteManyon the PVC to share it between the pods.