Skip to content

Added several Fortinet device types #1182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Mar 20, 2023
Merged

Added several Fortinet device types #1182

merged 12 commits into from
Mar 20, 2023

Conversation

desnoe
Copy link
Contributor

@desnoe desnoe commented Mar 7, 2023

No description provided.

danner26
danner26 requested changes Mar 8, 2023
View reviewed changes
@danner26 danner26 added the status: revisions needed This issue requires additional information to be actionable label Mar 8, 2023
@danner26
Copy link
Member

danner26 commented Mar 8, 2023

I am going to make this PR a draft again, when it is ready to be re-reviewed please mark it as ready for review. Thanks!

@danner26 danner26 marked this pull request as draft March 8, 2023 20:44
@desnoe desnoe force-pushed the add-fortinet-devices branch from 47ec4c8 to bf3a6f8 Compare March 8, 2023 21:31
@desnoe desnoe marked this pull request as ready for review March 8, 2023 21:36
@danner26
Copy link
Member

danner26 commented Mar 9, 2023

Hello, unfortunately today we had to make a change to the schema in which weight is defined by. The upstream NetBox API requires weight to be passed to it in the following format:

weight: 12.01
weight_unit: lb

Due to this change, I have updated your branch against the current master. This might require you to update your PR, if you had weight currently defined, so that your PR is in-line with the new weight schema. If you have any issues, please let me know or refer to this PR for more information.

@desnoe desnoe force-pushed the add-fortinet-devices branch from 00bf09a to 56cca0c Compare March 10, 2023 08:02
@danner26
Copy link
Member

Hey @desnoe please ping me when this PR is ready for review. Thank you

@desnoe desnoe force-pushed the add-fortinet-devices branch from 56cca0c to a336d74 Compare March 10, 2023 15:03
@desnoe
Copy link
Contributor Author

desnoe commented Mar 10, 2023

@danner26, just rebased the branch, please go on.

danner26
danner26 requested changes Mar 12, 2023
View reviewed changes
danner26
danner26 requested changes Mar 12, 2023
View reviewed changes
@desnoe desnoe force-pushed the add-fortinet-devices branch from d641f47 to 24e41ef Compare March 17, 2023 08:54
@desnoe
Copy link
Contributor Author

desnoe commented Mar 17, 2023

@danner26 this should be better now, could you have a look at it please ?

@danner26 danner26 added status: accepted and removed status: revisions needed This issue requires additional information to be actionable labels Mar 20, 2023
@danner26 danner26 merged commit c400101 into netbox-community:master Mar 20, 2023
etherwrangler pushed a commit to etherwrangler/devicetype-library that referenced this pull request Jul 16, 2023
@desnoe @danner26
Added several Fortinet device types (netbox-community#1182)
470e456 
* added several Fortinet device types

* removed hot swappable power ports and added weight

* fixed weight type to array

* added airflow

* prepended fortinet to the slug

* prepended fortinet to the slug

* changed weight format

* reworked power supplies

---------

Co-authored-by: DESNOË Olivier (Canal Plus) <olivier.desnoe@canal-plus.com>
Co-authored-by: Daniel W. Anner <daniel.anner@danstechsupport.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danner26 danner26 danner26 approved these changes

Assignees
No one assigned
Labels
status: accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@desnoe @danner26