Cisco device and module types

[scoffman77]

I have created the following files to address the multiple devices and modules that my organization utilizes, which are not present in the device type-library. I thought others might like to have these for use in their environments.
Devices:
N7K-C7009.yaml
MDS-C9148-16P.yaml
MDS-C9148S.yaml
MDS-C9148T.yaml
N9K-C9372TX-E.yaml

Modules:
N7K-AC-6KW.yaml
N7K-C7009-FAB-2.yaml
N7K-C7009-FAN.yaml
N7K-F248XP-25E.yaml
N7K-F248XT-25E.yaml
N7K-SUP2.yaml
N7K-SUP2E.yaml

[danner26]

Hello, unfortunately today we had to make a change to the schema in which weight is defined by. The upstream NetBox API requires weight to be passed to it in the following format:

weight: 12.01
weight_unit: lb

Due to this change, I have updated your branch against the current master. This might require you to update your PR, if you had weight currently defined, so that your PR is in-line with the new weight schema. If you have any issues, please let me know or refer to this PR for more information.

[danner26]

I am going to mark this PR as a draft. When it is ready make it for review and feel free to @ me for re-review

[danner26]

Hey @scoffman77. We have updated the validation and testing process such that it will require everyone to adhere to the same standards setout by the pre-commit procedure/tests. This will vastly reduce my requirement to cleanup the repo every few weeks or more often based on merged PR quantity. The easiest way to fix formatting issues with this PR is to:

1. Merge master into this branch if you have not already (already done)
2. Clone the codebase using VSCode, if not done already, then switch to this branch (in your case it is just the master branch - in the future I recommend you make a new branch to base a PR on)
3. Install the repository requirements using pip3 install -r requirements.txt
4. Run pre-commit install command pre-commit install
5. Run pre-commit tasks pre-commit run -a

This should A) format yaml files appropriately, and B) ensure that all files adhere to the test steps. Fix any issues that are not fixed automatically, then you can go from there.

Alternatively, you can give me access to your forked repository and then I can fix the issues for you.

[danner26]

Probably best to name this PSU{module} so that port name conflicts don't occur

[danner26]

Probably best to name this PSU{module} so that port name conflicts don't occur

[DanSheps]

If you can fix up the checks I think this is good as long as the comments about the MDS switch end up being a nothing burger

[scoffman77]

If you can fix up the checks I think this is good as long as the comments about the MDS switch end up being a nothing burger

I've been slammed of late and I haven't figured out how to perform the pre-checks as laid out by Danner26. I don't have access to install what is needed on our implementation.

From Danner26:

1. Merge master into this branch if you have not already (already done)
2. Clone the codebase using VSCode, if not done already, then switch to this branch (in your case it is just the master branch - in the future I recommend you make a new branch to base a PR on)
3. Install the repository requirements using pip3 install -r requirements.txt
4. Run pre-commit install command pre-commit install
5. Run pre-commit tasks pre-commit run -a

This should A) format yaml files appropriately, and B) ensure that all files adhere to the test steps. Fix any issues that are not fixed automatically, then you can go from there.

[danner26]

@scoffman77 sorry about that, I was away on vacation. Can you give me access to your fork? I can fix the formatting errors if so.

[github-actions]

This PR has been automatically marked as stale because it has not had recent activity. It will be closed automatically if no further progress is made.

[github-actions]

This PR has been automatically closed due to lack of activity.