Added mikrotiks and fixed some #1109
Conversation
|
I am marking this PR as a draft, please ensure all checks are passing. Then let me know and I will re-review this PR. Thanks! |
danner26
added
the
status: revisions needed
|
Hello @danner26 |
| @@ -2,8 +2,10 @@ | |||
| manufacturer: MikroTik | |||
| model: CRS212-1G-10S-1S+IN | |||
| slug: crs212-1g-10s-1splus-in | |||
There was a problem hiding this comment.
Please add mikrotik- as a prefix to the slug
| --- | ||
| manufacturer: MikroTik | ||
| model: netPower 16P | ||
| slug: mikrotik_crs318-16p-2splus-out |
There was a problem hiding this comment.
Please add mikrotik- as a prefix to the slug, underscores shouldn't be used
device-types/MikroTik/RB260GSP.yaml
Outdated
| is_full_depth: false | ||
| u_height: 0 | ||
| airflow: passive | ||
| comments: '[MikroTik RB260GSP Datasheet](https://mikrotik.com/product/RB260GSP)' | ||
| slug: rb260gsp |
There was a problem hiding this comment.
Please add mikrotik- as a prefix to the slug
| --- | ||
| manufacturer: MikroTik | ||
| model: PowerBox | ||
| slug: mikrotik_rb750p-pbr2 |
There was a problem hiding this comment.
Please add mikrotik- as a prefix to the slug, underscores shouldn't be used
device-types/MikroTik/RB750UPr2.yaml
Outdated
| --- | ||
| manufacturer: MikroTik | ||
| model: hEX PoE lite | ||
| slug: mikrotik_rb750upr2 |
There was a problem hiding this comment.
Please add mikrotik- as a prefix to the slug, underscores shouldn't be used
device-types/MikroTik/RB960PGS.yaml
Outdated
| @@ -2,10 +2,10 @@ | |||
| manufacturer: MikroTik | |||
| model: RB960PGS | |||
| slug: rb960pgs | |||
There was a problem hiding this comment.
Please add mikrotik- as a prefix to the slug
| --- | ||
| manufacturer: MikroTik | ||
| model: Metal 2 | ||
| slug: mikrotik_rbmetal2shpn |
There was a problem hiding this comment.
Please add mikrotik- as a prefix to the slug, underscores shouldn't be used
| --- | ||
| manufacturer: MikroTik | ||
| model: Metal 5 | ||
| slug: mikrotik_rbmetal5shpn |
There was a problem hiding this comment.
Please add mikrotik- as a prefix to the slug, underscores shouldn't be used
| --- | ||
| manufacturer: MikroTik | ||
| model: Metal 52 ac | ||
| slug: mikrotik_rbmetalg-52shpacn |
There was a problem hiding this comment.
Please add mikrotik- as a prefix to the slug, underscores shouldn't be used
| @@ -2,8 +2,10 @@ | |||
| manufacturer: MikroTik | |||
| model: CRS212-1G-10S-1S+IN | |||
| slug: crs212-1g-10s-1splus-in | |||
| part_number: CRS212-1G-10S-1SplusIN | |||
There was a problem hiding this comment.
This should be part_number: CRS212-1G-10S-1S+IN to align with the datasheet
|
Hello, unfortunately today we had to make a change to the schema in which weight is defined by. The upstream NetBox API requires weight to be passed to it in the following format: Due to this change, I have updated your branch against the current master. This might require you to update your PR, if you had weight currently defined, so that your PR is in-line with the new weight schema. If you have any issues, please let me know or refer to this PR for more information. |
|
I started doing a similar thing in PR#1196 |
|
This PR has been automatically marked as stale because it has not had recent activity. It will be closed automatically if no further progress is made. |
I created the PR before adding or modifying new devices to check we agree about format and the data itself
Mikrotiks added:
Fixed: