Skip to content

Device types 2022 02 07 #1107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

requenag
Copy link
Contributor

@requenag requenag commented Feb 7, 2023

Hi,

This is a pull request to add some devices to the community device-types folder.

Thank you.

Regards,

@danner26
Copy link
Member

Looks like your build is still failing. Please utilize pre-commit run to fix any issues

For the time being I have marked this as a draft PR until the issues are resolved. Please let me know once things are ready. Thanks!

@danner26 danner26 marked this pull request as draft February 13, 2023 16:24
@danner26 danner26 added the status: revisions needed This issue requires additional information to be actionable label Feb 13, 2023
@danner26
Copy link
Member

danner26 commented Mar 9, 2023

Hello, unfortunately today we had to make a change to the schema in which weight is defined by. The upstream NetBox API requires weight to be passed to it in the following format:

weight: 12.01
weight_unit: lb

Due to this change, I have updated your branch against the current master. This might require you to update your PR, if you had weight currently defined, so that your PR is in-line with the new weight schema. If you have any issues, please let me know or refer to this PR for more information.

@github-actions
Copy link
Contributor

This PR has been automatically marked as stale because it has not had recent activity. It will be closed automatically if no further progress is made.

@github-actions github-actions bot added the stale label Apr 16, 2023
@github-actions
Copy link
Contributor

This PR has been automatically closed due to lack of activity.

@github-actions github-actions bot closed this Apr 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale status: revisions needed This issue requires additional information to be actionable
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants