Skip to content

add NEC UNIVERGE IX2105 IX2207 IX3110 #1057

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Mar 28, 2023
Merged

Conversation

nxzz
Copy link
Contributor

@nxzz nxzz commented Jan 17, 2023

This pull request adds more NEC UNIVERGE IX series routers (IX2105 IX2207 IX3110).

The product datasheet can be found below.
I couldn't find an English datasheet, so it's only a Japanese datasheet.
https://jpn.nec.com/univerge/ix/Info/ix2105.html
https://jpn.nec.com/univerge/ix/Spec/hw-spec.html#ix2207
https://jpn.nec.com/univerge/ix/Spec/hw-spec-ix3000.html#ix3110

Copy link
Member

@danner26 danner26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please review my questions. Are the ports actually referred to in the config as GigaEthernet 1 port 1? Or are they more like the UNIVERGE IX3110 GigaEthernet1, GigaEthernet2 and so on?

If they are in fact like you have them defined, a sample output of the device config would be appreciated.. Thanks!

@danner26 danner26 added the status: revisions needed This issue requires additional information to be actionable label Jan 17, 2023
@nxzz
Copy link
Contributor Author

nxzz commented Jan 18, 2023

Thank you for your review.

In the NEC IX series, the interface that operates as a switching hub is called "GigaEthernetX port Y".
Otherwise, GigaEthernetX only.

@nxzz nxzz requested a review from danner26 January 18, 2023 12:41
@danner26
Copy link
Member

Thanks for all of your work @nxzz
One last thing, for USB0 I see that you mentioned they are mainly for USB LTE additions. How do you plan on using this in NetBox?

@danner26 danner26 added the question Further information is requested label Jan 18, 2023
@nxzz
Copy link
Contributor Author

nxzz commented Jan 18, 2023

I would like to define an LTE modem as a device ,
and show that the LTE modem is connected to router.
If this is not a good way to indicate an LTE modem is connected, I would remove the USB.

@danner26 danner26 added the help wanted Extra attention is needed label Jan 18, 2023
@danner26
Copy link
Member

I am discussing internally with the maintainers on how to best handle this, feel free to ping me if you dont hear back in a few days

@nxzz
Copy link
Contributor Author

nxzz commented Jan 23, 2023

Hi @danner26 .
is there any progress?

@danner26
Copy link
Member

Hey @nxzz still working on this, the team is very busy at the moment and unfortunately this has fallen down the list. I will try to get it some more attention ASAP

Reach back out in another week or two if you dont hear back.. I am sorry

@github-actions
Copy link
Contributor

This PR has been automatically marked as stale because it has not had recent activity. It will be closed automatically if no further progress is made.

@github-actions github-actions bot added the stale label Feb 25, 2023
@danner26
Copy link
Member

Hey @nxzz while I was cleaning up some other devices I realized that there is an interface type lte. I saw other devices are using lte as the interface type and calling the port USB0 or something like that. Would that work for your implementation? If so I will double check with the other maintainers and make sure it works for everyone.

@danner26 danner26 removed the stale label Feb 27, 2023
@danner26
Copy link
Member

danner26 commented Mar 9, 2023

Hello, unfortunately today we had to make a change to the schema in which weight is defined by. The upstream NetBox API requires weight to be passed to it in the following format:

weight: 12.01
weight_unit: lb

Due to this change, you will be required to fix the current conflicts and then update your PR with the current master branches codebase. This might require you to update your PR, if you had weight currently defined, so that your PR is in-line with the new weight schema. If you have any issues, please let me know or refer to this PR for more information.

@nxzz
Copy link
Contributor Author

nxzz commented Mar 17, 2023

Added weight to the definition.
Changed USB0/USB1 type to lte.

@danner26
For my purposes, no network devices other than LTE modems are expected to be connected to USB0/USB1 on the IX series, so setting the type to lte solves this problem.

@danner26 danner26 removed help wanted Extra attention is needed question Further information is requested labels Mar 20, 2023
@nxzz nxzz requested a review from danner26 March 20, 2023 08:45
@danner26 danner26 added status: accepted and removed status: revisions needed This issue requires additional information to be actionable labels Mar 28, 2023
@danner26 danner26 merged commit 88697ee into netbox-community:master Mar 28, 2023
etherwrangler pushed a commit to etherwrangler/devicetype-library that referenced this pull request Jul 16, 2023
* add NEC UNIVERGE IX2105 IX2207 IX3110

* remove extra newline

* add weight UNIVERGE IX2105 IX2207 IX3110

* change  UNIVERGE IX2207 USB0/1 type to lte

* add nec slug

* PSU definition for IX3110

---------

Co-authored-by: Daniel W. Anner <daniel.anner@danstechsupport.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants