Fix sevral integration tests failure

[benoit-ferre]

Fix sevral bugs dicovered by integration tests failure

Related Issue

N/A
I did not find any open issue and I fix tem directly without fill a bug.

• Fix service creation with netbox prior of 4.3.0 (since fixes #1426 : broken netbox_service module #1427 I think)
• Use dedicated function to check netbox version istead of self.full_version for rack.
• Fix typos in tag integration tests.
• Fix integration test for circuit termination, missing assignment
• Fix integration test for service

New Behavior

Only bug fix

Contrast to Current Behavior

N/A

Discussion: Benefits and Drawbacks

Bug fix

Changes to the Documentation

N/A

Proposed Release Note Entry

• Add netbox version check to support service creation for netbox version prior of 4.3

Double Check

• I have read the comments and followed the CONTRIBUTING.md.
• I have explained my PR according to the information in the comments or in a linked issue.
• My PR targets the devel branch.

[StoffelCPR]

Hey,

If you want take a look into the integration test targets 4.2 and 4.3. Technically they're failing. You just can't see it because the printout of the JSON debug output fails and the exit(1) is never reached.

I'm trying to fix that in my pull request but I've just started looking at this source code. If you're faster that'd be greatly aprpeciated. #1438

[benoit-ferre]

Hello @StoffelCPR ,
I saw there is a problem with service since version 4.2.
But I was only focused in making unit tests passing again in this PR.
For unit services tests I think my solution is more a workaround than a fix. I did not analyse so much.
You can open a new discussion an reference it on your PR so we can dicuss of this in there.

[StoffelCPR]

Alright I will

[sc68cal]

@benoit-ferre thank you for contributing this, this gets our testing infrastructure back in the green!