Fix sevral integration tests failure #1437
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add custom header parameter based on @clinta work in netbox-community#1327
Reflect signature change in the doc file: `modified: docs/getting_started/contributing/modules/architecture.rst`
Add netbox version check to support service creation for netbox version prior of 4.3
Use dedicated function to check netbox version istead of self.full_version for rack.
When creating service with a service with an existing name on vm the check fail
benoit-ferre
force-pushed
the
fix_integration-tests
branch
from
af54983 to
cde4a70
Compare
benoit-ferre
force-pushed
the
fix_integration-tests
branch
from
6a6bf9f to
ba47604
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix sevral bugs dicovered by integration tests failure
Related Issue
N/A
I did not find any open issue and I fix tem directly without fill a bug.
New Behavior
Only bug fix
Contrast to Current Behavior
N/A
Discussion: Benefits and Drawbacks
Bug fix
Changes to the Documentation
N/A
Proposed Release Note Entry
Double Check
develbranch.