Handle netbox api cache more gracefully #1111
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are instances where we fail to read the cached netbox_api_dump.json file, and the code was setting openapi to an empty dictionary, and netbox_api_version to 0. This is not correct, because we can still fetch the netbox_api_version by querying the live server. In addition, in cases where the cached API was failing to read, it would end up triggering the if/else statement to try and access the older API doc endpoint, even if the server was not < 3.5.0 Overall the code was very convoluted and could break if the cached file was not readable or writable. This patch cleans the logic up and makes it more clear what is going on.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #1106