New profile: loupe #6327
Merged
New profile: loupe #6327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glitsj16
reviewed
May 1, 2024
glitsj16
reviewed
May 1, 2024
glitsj16
reviewed
May 1, 2024
glitsj16
reviewed
May 1, 2024
glitsj16
reviewed
May 1, 2024
Signed-off-by: Tavi <tavi@divested.dev>
|
Merged, thanks @glitsj16! |
kmk3
reviewed
May 1, 2024
kmk3
added a commit
to kmk3/firejail
that referenced
this pull request
May 8, 2024
The profile currently does not include disable-common nor makes
`${HOME}` read-only, so the program can simply write to ~/.bashrc
directly[1].
This amends commit 9a0db13 ("profiles: add loupe", 2024-04-30) /
PR netblue30#6327.
[1] netblue30#6327 (review)
kmk3
added a commit
to kmk3/firejail
that referenced
this pull request
May 8, 2024
The profile currently does not include disable-common nor makes
`${HOME}` read-only, so the program can simply write to ~/.bashrc
directly[1].
disable-common.inc was commented due to it apparently breaking bwrap.
As discovered by @glitsj16, it seems that allowing the bwrap binary is
enough to make it work (and that apparmor breaks loupe)[2].
So disable apparmor, allow bwrap and include disable-common.inc, plus
other hardening by @glitsj16.
This amends commit 9a0db13 ("profiles: add loupe", 2024-04-30) /
PR netblue30#6327.
[1] netblue30#6327 (review)
[2] netblue30#6333 (comment)
kmk3
added a commit
that referenced
this pull request
May 12, 2024
The profile currently does not include disable-common nor makes
`${HOME}` read-only, so the program can simply write to ~/.bashrc
directly[1].
disable-common.inc was commented due to it apparently breaking bwrap.
As discovered by @glitsj16, it seems that allowing the bwrap binary is
enough to make it work (and that apparmor breaks loupe)[2].
So disable apparmor, allow bwrap and include disable-common.inc, plus
other hardening by @glitsj16.
This amends commit 9a0db13 ("profiles: add loupe", 2024-04-30) /
PR #6327.
[1] #6327 (review)
[2] #6333 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
works but can be improved
loupe opens each image in its own sandbox using bwrap if available
largely copy/pasted from eo-common