firecfg: use ignorelist also for .profile/.desktop files #6153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently it is only used when parsing the configuration files: * /etc/firecfg.d/*.conf * /etc/firecfg.config Use it when searching for profile filenames as well: * ~/.config/firejail/*.profile Relates to netblue30#5876.
kmk3
force-pushed
the
firecfg-ignorelist-extra
branch
from
f1f6187
to
cc2d087
Compare
Changes: * Export `in_ignorelist` function * Allow only building the ignorelist without setting the symlinks * Rename the functions to reflect the above * Add a function that parses all config files (`parse_config_all`) Also, make sure that `parse_config_all` only parses config files once, even if called multiple times. Relates to netblue30#5876.
And make it const.
Closes netblue30#5245. Relates to netblue30#5876.
kmk3
force-pushed
the
firecfg-ignorelist-extra
branch
from
cc2d087
to
a9c851e
Compare
7 tasks
glitsj16
approved these changes
Jan 11, 2024
kmk3
added a commit
that referenced
this pull request
Jan 20, 2024
kmk3
added a commit
to kmk3/firejail
that referenced
this pull request
Mar 8, 2024
Based on the discussion at netblue30#5063. Misc: The `\&` is used to escape the dot in `.desktop` (see roff(7)). Relates to netblue30#6153.
kmk3
added a commit
to kmk3/firejail
that referenced
this pull request
Mar 14, 2024
Based on the discussion at netblue30#5063. Misc: The `\&` is used to escape the dot in `.desktop` (see roff(7)). This amends commit a9c851e ("firecfg: use ignorelist also for .desktop files", 2024-01-08) / PR netblue30#6153.
kmk3
added a commit
that referenced
this pull request
Mar 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently it is only used when parsing the configuration files:
Use it when searching for .profile and .desktop files as well:
Closes #5245.
Relates to #5876.