DHCP client code quality fixes #3190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Caused build failure in Travis (due to lack of C99 mode): sbox.c: In function ‘sbox_run_v’: sbox.c:185:3: error: ‘for’ loop initial declarations are only allowed in C99 mode for (int i = 3; i < max; i++) ^ sbox.c:185:3: note: use option -std=c99 or -std=gnu99 to compile your code
Travis uses |
rusty-snake
reviewed
Jan 28, 2020
kmk3
pushed a commit
to glitsj16/firejail
that referenced
this pull request
Sep 1, 2024
Sort commands and sections in firejail.1.in and sync the result with firejail-profile.5.in. * Commands: `--dbus-system.*`, `--dbus-user.*`, `--icmptrace`, `--ip=none`, `memory-deny-write-execute`, `--noinput` * Sections: "LANDLOCK", "NAME VALIDATION" Relates to netblue30#3190 netblue30#3406 netblue30#4209 netblue30#5856 netblue30#6078.
kmk3
pushed a commit
to glitsj16/firejail
that referenced
this pull request
Sep 10, 2024
Sort commands in firejail.1.in and sync the result with firejail-profile.5.in. * Commands: `--dbus-system.*`, `--dbus-user.*`, `--icmptrace`, `--ip=none`, `memory-deny-write-execute`, `--noinput` Relates to netblue30#3190 netblue30#3406 netblue30#4209.
kmk3
pushed a commit
that referenced
this pull request
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I finally had some time to fix up my implementation for DHCP client support. Sorry for the delay!
git blameoutput a bit, so it is debatable whether we should merge it.-Werror.By the way, there seem to be some differences between default CFLAGS produces by
./configureon my machine and on Travis.Compiling withThanks for @Vincent43 for pointing out the-Wall -Wextra -Werrorseems prudent, but does not happen for me locally../configure --enable-fatal-warningsoption! On the other hand, on Travis, C99 support is not enabled. Travis also uses older netlink headers, I think, for example, it does not defineIFA_FLAGS.