RPM build fixes #297
Merged
RPM build fixes #297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Merged, thanks! |
kmk3
added a commit
to kmk3/firejail
that referenced
this pull request
Feb 7, 2024
To make the CI logs more informative, as currently nothing from the build itself is shown. Added on commit d684d99 ("Fix mkrpm.sh", 2016-02-16) / PR netblue30#297.
kmk3
added a commit
to kmk3/firejail
that referenced
this pull request
Feb 7, 2024
To make the CI logs more informative, as currently nothing from the build itself is shown. Added on commit d684d99 ("Fix mkrpm.sh", 2016-02-16) / PR netblue30#297.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the issues noted in issue #296 and in particular brings rpm building into the make system. With these changes the sequence './configure && make rpms' produces the app/debug/source rpms in cwd. I have built and installed the resulting rpm on Fedora 23 and verified that it works running Firefox.
More generally this removes redundant information that needs to be kept up to date manually, e.g. the version is passed by the Makefile automatically and added to the spec rather than being duplicated there. A future enhancement could add always-up-to-date changelog entries by munging RELNOTES.
Finally, this version is much, much simpler than the existing scripts at only 40 LOC.