Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vscodium: missing profile redirect for codium #6461

Closed
MiltiadisKoutsokeras opened this issue Sep 3, 2024 · 11 comments
Closed

vscodium: missing profile redirect for codium #6461

MiltiadisKoutsokeras opened this issue Sep 3, 2024 · 11 comments
Labels
duplicate This issue or pull request already exists old-version Issues caused by using an old version of firejail

Comments

@MiltiadisKoutsokeras
Copy link

Is your feature request related to a problem? Please describe.

Firejail does not contain a profile to support the latest VSCodium in the apt package of Debian 11.

Describe the solution you'd like

I would like the Firejail installation to contain a profile that supports the latest VSCodium, as it does with past versions in files:

  • /etc/firejail/code-oss.profile
  • /etc/firejail/vscodium.profile

Describe alternatives you've considered

It would be possible to create a local custom file for latest VSCodium version but the program details have changed from the previous versions (whitelisted direcotries, privileges, etc.).

@kmk3
Copy link
Collaborator

kmk3 commented Sep 3, 2024

Basic debugging information is missing; please follow the bug report template:

@kmk3 kmk3 added the needinfo More information is needed from the issue author label Sep 3, 2024
@MiltiadisKoutsokeras
Copy link
Author

I would happily do that, but it is not a BUG. It is a feature request to provide a profile for the latest version of a program.

@rusty-snake
Copy link
Collaborator

Moved

@rusty-snake rusty-snake closed this as not planned Won't fix, can't repro, duplicate, stale Sep 4, 2024
@MiltiadisKoutsokeras
Copy link
Author

Thanks, you can close this.

@kmk3
Copy link
Collaborator

kmk3 commented Sep 4, 2024

I would happily do that, but it is not a BUG. It is a feature request to
provide a profile for the latest version of a program.

Profiles are generally not separated by program versions (with limited
exceptions for new major versions of certain programs), they are created based
on the name of the executable.

Is there a new executable name for vscodium?

If not, there already exists a profile for vscodium and it either works
properly or it doesn't.

If it doesn't work, it's a bug.

the program details have changed from the previous versions (whitelisted
direcotries, privileges, etc.).

Which directories and privileges?

In what version of vscodium did they change?

@MiltiadisKoutsokeras
Copy link
Author

Profiles are generally not separated by program versions (with limited exceptions for new major versions of certain programs), they are created based on the name of the executable.

Is there a new executable name for vscodium?

The executable is renamed to codium so none of the provided profiles match (even if they did, the contents would not apply).

If it doesn't work, it's a bug.

Well then it is a BUG.

Which directories and privileges?

If I had a complete list for those, I would happily create and share the profile. You have to communicate with the developers for that.

In what version of vscodium did they change?

Unfortunately I do not know this, I realized that firejail did not apply a profile recently while researching another issue.

@rusty-snake
Copy link
Collaborator

rusty-snake commented Sep 4, 2024

The executable is renamed to codium so none of the provided profiles match

https://github.com/netblue30/firejail/blob/master/etc/profile-a-l/codium.profile added 3 years ago. Also in

So yes basic debugging information like your firejail version are missing.

@MiltiadisKoutsokeras
Copy link
Author

MiltiadisKoutsokeras commented Sep 4, 2024

Here are my versions:

  • Linux distribution and version: Debian 11
  • Firejail version (firejail --version): 0.9.64.4

It seems that the package is old enough and includes outdated profiles. I will try to copy the upstream ones. The only profile installed is /etc/firejail/vscodium.profile with contents:

# Firejail profile alias for Visual Studio Code
# This file is overwritten after every install/update

# Persistent local customizations
include vscodium.local

noblacklist ${HOME}/.VSCodium

# Redirect
include code.profile

This is probably something the Debian maintainer should do, so please close the report.

@kmk3
Copy link
Collaborator

kmk3 commented Sep 4, 2024

@MiltiadisKoutsokeras on Sep 4:

  • Firejail version (firejail --version): 0.9.64.4

Note that we do not maintain that version of firejail:

Versions other than the latest usually have outdated profiles and may contain
bugs and security vulnerabilities that were fixed in later versions.

This is probably something the Debian maintainer should do, so please close
the report.

I think it's unlikely to be upgraded on a stable Debian release.

See also the recommended way to install firejail on Debian:

@kmk3
Copy link
Collaborator

kmk3 commented Sep 4, 2024

Duplicate of #3871

@kmk3 kmk3 marked this as a duplicate of #3871 Sep 4, 2024
@kmk3 kmk3 added duplicate This issue or pull request already exists and removed needinfo More information is needed from the issue author labels Sep 4, 2024
@kmk3 kmk3 changed the title Support for the latest VSCodium vscodium: missing profile redirect for codium Sep 4, 2024
@kmk3 kmk3 added the old-version Issues caused by using an old version of firejail label Sep 4, 2024
@rusty-snake
Copy link
Collaborator

I will try to copy the upstream ones.

Does not necessarily work, the profile may use commands unknown by your firejail version or include other profiles you don't have or with wrong content.

kmk3 added a commit to kmk3/firejail that referenced this issue Sep 10, 2024
Changes:

* Sync bug_report.md with build_issue.md (reword items and add Linux
  kernel item)
* Add a colon to the end of every item (to clarify where to add the
  information)
* Add the Environment section to feature_request.md

The last item is intended as a basic sanity check, as users using an
outdated version of firejail may request something that was already
implemented (for example, see netblue30#6461).

Relates to netblue30#4515 netblue30#6423.
kmk3 added a commit to kmk3/firejail that referenced this issue Sep 13, 2024
Changes:

* Sync bug_report.md with build_issue.md (reword items and add Linux
  kernel item)
* Add a colon to the end of every item (to clarify where to add the
  information)
* Add the Environment section to feature_request.md

The last item is intended as a basic sanity check, as users using an
outdated version of firejail may request something that was already
implemented (for example, see netblue30#6461).

Relates to netblue30#4515 netblue30#6423.
kmk3 added a commit that referenced this issue Sep 13, 2024
Changes:

* Sync bug_report.md with build_issue.md (reword items and add Linux
  kernel item)
* Add a colon to the end of every item (to clarify where to add the
  information)
* Add the Environment section to feature_request.md

The last item is intended as a basic sanity check, as users using an
outdated version of firejail may request something that was already
implemented (for example, see #6461).

Relates to #4515 #6423.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue or pull request already exists old-version Issues caused by using an old version of firejail
Projects
None yet
Development

No branches or pull requests

3 participants