Mobile prerefactor #680
Merged
Mobile prerefactor #680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Exported first
gigovich
reviewed
Feb 9, 2023
- replace \" to ` - use %w instead of %v
gigovich
previously approved these changes
Feb 10, 2023
braginini
approved these changes
Feb 13, 2023
pulsastrix
pushed a commit
to pulsastrix/netbird
that referenced
this pull request
Dec 24, 2023
Small code cleaning in the iface package. These changes necessary to get a clean code in case if we involve more platforms. The OS related functions has been distributed into separate files and it has been mixed with not OS related logic. The goal is to get a clear picture of the layer between WireGuard and business logic.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Small code cleaning in the iface package. These changes necessary to get a clean code in case if we involve more platforms.
The OS related functions has been distributed into separate files and it has been mixed with not OS related logic. The goal is to get a clear picture of the layer between Wirequard and business logic.
Main problem
Unfortunately the Android implementation of Wrieguard tool does not fit with the original Wireguard approach.
Until now the service communicated with the wireguard device via wgctrl package on every OS. In Android it is not possible so we have to create some new function what doing almost the same what the wgctrl did. I would like to provide a well layered solution.
Changes
Issue ticket number and link
Checklist