[managament] sync all other peers on peer add/remove #4614
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes conditional logic for peer synchronization and makes all peers sync on peer add/remove operations regardless of group membership status. The change simplifies the code by removing the isPeerInActiveGroup check and always triggering peer updates.
- Removes conditional logic that checked if a peer was in an active group before triggering synchronization
- Ensures all other peers are notified when any peer is added or removed from the account
- Simplifies the codebase by removing the
updateAccountPeersvariable and related logic
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| if updateAccountPeers { | ||
| am.BufferUpdateAccountPeers(ctx, accountID) | ||
| } | ||
| am.BufferUpdateAccountPeers(ctx, accountID) |
There was a problem hiding this comment.
The removal of the conditional check causes this line to be unconditionally executed, but it's missing proper indentation. The line should be properly aligned with the surrounding code block.
pascal-fischer
previously approved these changes
Oct 9, 2025
…or unlinked groups
pascal-fischer
previously approved these changes
Oct 9, 2025
management/server/group_test.go
Outdated
| case <-done: | ||
| case <-time.After(time.Second): | ||
| t.Error("timeout waiting for peerShouldNotReceiveUpdate") | ||
| t.Error("timeout waiting for peerShouldReceiveUpdate") |
Collaborator
There was a problem hiding this comment.
Why did the log change?
|
pascal-fischer
approved these changes
Oct 9, 2025
hurricanehrndz
added a commit
to hurricanehrndz/netbird
that referenced
this pull request
Oct 24, 2025
* upstream/main: (135 commits) [signal] Fix HTTP/WebSocket proxy not using custom certificates (netbirdio#4644) [client] Fix active profile name in debug bundle (netbirdio#4689) [management] Add peer disapproval reason (netbirdio#4468) [misc] Update tag name extraction in install.sh (netbirdio#4677) [client] Clean up match domain reg entries between config changes (netbirdio#4676) [client] Delete TURNConfig section from script (netbirdio#4639) [client] Security upgrade alpine from 3.22.0 to 3.22.2 netbirdio#4618 [client] Fix status showing P2P without connection (netbirdio#4661) [client] Support BROWSER env for login (netbirdio#4654) [client] Remove rule squashing (netbirdio#4653) Handle the case when the service has already been down and the status recorder is not available (netbirdio#4652) [client] Set default wg port for new profiles (netbirdio#4651) [client] Add bind activity listener to bypass udp sockets (netbirdio#4646) [client] Fix missing flag values in profiles (netbirdio#4650) [management] feat: Basic PocketID IDP integration (netbirdio#4529) [client] Force TLS1.2 for RDP with Win11/Server2025 for CredSSP compatibility (netbirdio#4617) [misc] Add service definition for netbird-signal (netbirdio#4620) [management] pass temporary flag to validator (netbirdio#4599) [client] Explicitly disable DNSOverTLS for systemd-resolved (netbirdio#4579) [management] sync all other peers on peer add/remove (netbirdio#4614) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
[managament] sync all other peers on peer add/remove
Issue ticket number and link
Stack
Checklist
Documentation
Select exactly one:
.
Docs PR URL (required if "docs added" is checked)
Paste the PR link from https://github.com/netbirdio/docs here:
https://github.com/netbirdio/docs/pull/__