Skip to content

Conversation

lixmal
Copy link
Collaborator

@lixmal lixmal commented Oct 6, 2025

Describe your changes

Issue ticket number and link

Stack

Checklist

  • Is it a bug fix
  • Is a typo/documentation fix
  • Is a feature enhancement
  • It is a refactor
  • Created tests that fail without the change (if possible)

By submitting this pull request, you confirm that you have read and agree to the terms of the Contributor License Agreement.

Documentation

Select exactly one:

  • I added/updated documentation for this change
  • Documentation is not needed for this change (explain why)

Docs PR URL (required if "docs added" is checked)

Paste the PR link from https://github.com/netbirdio/docs here:

https://github.com/netbirdio/docs/pull/__

@Copilot Copilot AI review requested due to automatic review settings October 6, 2025 20:02
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Removes the per-iteration read deadline in the WebSocket proxy pipe loop, presumably to avoid premature timeouts or unnecessary deadline churn.

  • Eliminates SetReadDeadline calls before each pipeConn.Read
  • Simplifies the pipeToWS read loop

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link

sonarqubecloud bot commented Oct 6, 2025

@lixmal lixmal merged commit 8846788 into main Oct 6, 2025
35 of 36 checks passed
@lixmal lixmal deleted the remove-read-deadline branch October 6, 2025 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants