-
-
Notifications
You must be signed in to change notification settings - Fork 899
[client,gui] Update url_windows.go to offer arm64 executable download #4586
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. I've left a small suggestion that alignes better to Go's style.
Thanks @mlsmaycon - I'm not at all a 'go' coder, so was just doing my best to copy a pattern used by netbird in one of the other distros; but I can definitely see how this is much better. Should all be ready to go now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @webash appreciate the contribution
|
Describe your changes
When the Windows arm64 client detects an update, it offers the amd64 download URL instead of the arm64 one; so I borrowed the selection pattern from the macOS client's url_darwin.go
Issue ticket number and link
Relates to #2317
Stack
Checklist
Documentation
Select exactly one:
Docs PR URL (required if "docs added" is checked)
Paste the PR link from https://github.com/netbirdio/docs here:
https://github.com/netbirdio/docs/pull/__