Skip to content

Conversation

webash
Copy link
Contributor

@webash webash commented Oct 4, 2025

Describe your changes

When the Windows arm64 client detects an update, it offers the amd64 download URL instead of the arm64 one; so I borrowed the selection pattern from the macOS client's url_darwin.go

Issue ticket number and link

Relates to #2317

Stack

Checklist

  • Is it a bug fix
  • Is a typo/documentation fix
  • Is a feature enhancement
  • It is a refactor
  • Created tests that fail without the change (if possible)

By submitting this pull request, you confirm that you have read and agree to the terms of the Contributor License Agreement.

Documentation

Select exactly one:

  • I added/updated documentation for this change
  • Documentation is not needed for this change (explain why)

Docs PR URL (required if "docs added" is checked)

Paste the PR link from https://github.com/netbirdio/docs here:

https://github.com/netbirdio/docs/pull/__

@CLAassistant
Copy link

CLAassistant commented Oct 4, 2025

CLA assistant check
All committers have signed the CLA.

Copy link
Collaborator

@mlsmaycon mlsmaycon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I've left a small suggestion that alignes better to Go's style.

@webash
Copy link
Contributor Author

webash commented Oct 7, 2025

Thanks @mlsmaycon - I'm not at all a 'go' coder, so was just doing my best to copy a pattern used by netbird in one of the other distros; but I can definitely see how this is much better.

Should all be ready to go now.

mlsmaycon
mlsmaycon previously approved these changes Oct 8, 2025
Copy link
Collaborator

@mlsmaycon mlsmaycon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @webash appreciate the contribution

Copy link

sonarqubecloud bot commented Oct 8, 2025

@mlsmaycon mlsmaycon changed the title Update url_windows.go to offer arm64 executable download [client,gui] Update url_windows.go to offer arm64 executable download Oct 8, 2025
@mlsmaycon mlsmaycon merged commit 654aa95 into netbirdio:main Oct 8, 2025
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants