Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update google.golang.org/api to latest #3288

Merged
merged 9 commits into from
Feb 21, 2025

Conversation

paralin
Copy link
Contributor

@paralin paralin commented Feb 5, 2025

Updating google.golang.org/api library to fix indirect dependency issues with older versions of OpenTelemetry.

See: #3240

This PR also includes required updates to dependencies of google.golang.org/api separated into one commit per dependency.

Ignore the vendor/ tree created if someone runs "go mod vendor"

Signed-off-by: Christian Stewart <christian@aperture.us>
Updating protobuf runtime library as a dependency of eventually updating
google.golang.org/api in a future commit.

Signed-off-by: Christian Stewart <christian@aperture.us>
Updating grpc library as a dependency of eventually updating
google.golang.org/api in a future commit.

Signed-off-by: Christian Stewart <christian@aperture.us>
Updating x/net library as a dependency of eventually updating
google.golang.org/api in a future commit.

Signed-off-by: Christian Stewart <christian@aperture.us>
Updating x/oauth2 library as a dependency of eventually updating
google.golang.org/api in a future commit.

Signed-off-by: Christian Stewart <christian@aperture.us>
…test

Updating testify library as a dependency of eventually updating
google.golang.org/api in a future commit.

Signed-off-by: Christian Stewart <christian@aperture.us>
Updating otel library as a dependency of eventually updating
google.golang.org/api in a future commit.

Signed-off-by: Christian Stewart <christian@aperture.us>
Updating x/time library as a dependency of eventually updating
google.golang.org/api in a future commit.

Signed-off-by: Christian Stewart <christian@aperture.us>
Updating google.golang.org/api library to fix indirect dependency issues with
older versions of OpenTelemetry.

See: netbirdio#3240

Signed-off-by: Christian Stewart <christian@aperture.us>
Copy link

sonarqubecloud bot commented Feb 5, 2025

@paralin
Copy link
Contributor Author

paralin commented Feb 5, 2025

I can't see what dependency made snyk fail - any guidance? @lixmal Thanks!

@lixmal
Copy link
Contributor

lixmal commented Feb 5, 2025

This is what it's complaining about
image

@paralin
Copy link
Contributor Author

paralin commented Feb 5, 2025

@lixmal Those say that it was fixed in protobuf version 1.33.0 but we are using version 1.36.4 here. So, the fix should already be included. Any ideas why snyk is thinking we have google.golang.org/protobuf less than 1.33.0? I think this is a false positive:

https://github.com/googleapis/google-cloud-go/blob/main/compute/metadata/go.mod

cloud.google.com/go/compute/metadata does not import google.golang.org/protobuf at all.

@lixmal
Copy link
Contributor

lixmal commented Feb 5, 2025

@mlsmaycon do you know how to fix these? I think we had that before

@lixmal lixmal merged commit a854660 into netbirdio:main Feb 21, 2025
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants