Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Windows file version #2380

Merged
merged 1 commit into from
Aug 2, 2024
Merged

Fix Windows file version #2380

merged 1 commit into from
Aug 2, 2024

Conversation

mlsmaycon
Copy link
Collaborator

@mlsmaycon mlsmaycon commented Aug 2, 2024

Describe your changes

Systems that validates the binary version didn't like the build number as we set

This fixes the versioning and will use a static build number

To validate the version output you can run the following command in powershell:

[System.Diagnostics.FileVersionInfo]::GetVersionInfo('C:\Program Files\Netbird\netbird.exe')

ProductVersion   FileVersion      FileName
--------------   -----------      --------
0.28.7.0          0.28.7.0          C:\Program Files\Netbird\netbird.exe

Issue ticket number and link

Checklist

  • Is it a bug fix
  • Is a typo/documentation fix
  • Is a feature enhancement
  • It is a refactor
  • Created tests that fail without the change (if possible)
  • Extended the README / documentation, if necessary

Systems that validates the binary version didn't like the build number as we set

This fixes the versioning and will use a static build number
Copy link

sonarqubecloud bot commented Aug 2, 2024

@mlsmaycon mlsmaycon merged commit e6f7222 into main Aug 2, 2024
22 checks passed
@mlsmaycon mlsmaycon deleted the fix/windows-file-version branch August 2, 2024 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants