Validate input of expiration time for setup-keys #1053
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So far we accepted any value for setup keys, including negative values Now we are checking if it is less than 1 day or greater than 365 days
bcmmbaga
reviewed
Aug 4, 2023
bcmmbaga
approved these changes
Aug 4, 2023
surik
pushed a commit
to surik/netbird
that referenced
this pull request
Aug 11, 2023
So far we accepted any value for setup keys, including negative values Now we are checking if it is less than 1 day or greater than 365 days
surik
pushed a commit
to surik/netbird
that referenced
this pull request
Aug 14, 2023
So far we accepted any value for setup keys, including negative values Now we are checking if it is less than 1 day or greater than 365 days
pulsastrix
pushed a commit
to pulsastrix/netbird
that referenced
this pull request
Dec 24, 2023
So far we accepted any value for setup keys, including negative values Now we are checking if it is less than 1 day or greater than 365 days
Foosec
pushed a commit
to Foosec/netbird
that referenced
this pull request
May 8, 2024
So far we accepted any value for setup keys, including negative values Now we are checking if it is less than 1 day or greater than 365 days
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
So far we accepted any value for setup keys, including negative values
Now we are checking if it is less than 1 day or greater than 365 days
Issue ticket number and link
netbirdio/dashboard#251
Checklist