Add CrowdSec AppSec mode to reverse proxy access control - #734
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (8)
🚧 Files skipped from review as they are similar to previous changes (8)
📝 WalkthroughWalkthroughAdds AppSec mode contracts and capability flags, a supported-domain configuration selector, AppSec restriction summaries, cluster feature badges, and AppSec event method and verdict displays. ChangesReverse proxy AppSec support
Estimated code review effort: 3 (Moderate) | ~25 minutes Sequence Diagram(s)sequenceDiagram
participant ReverseProxyModal
participant ReverseProxyAccessControlRules
participant ReverseProxyAppSecInspection
participant ReverseProxyAccessControlCell
ReverseProxyModal->>ReverseProxyAccessControlRules: pass supported-domain AppSec capability
ReverseProxyAccessControlRules->>ReverseProxyAppSecInspection: render selected AppSec mode
ReverseProxyAppSecInspection->>ReverseProxyAccessControlRules: return selected mode
ReverseProxyAccessControlRules->>ReverseProxyModal: emit restrictions with appsec_mode
ReverseProxyAccessControlCell->>ReverseProxyAccessControlCell: summarize AppSec restriction state
Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
src/interfaces/ReverseProxy.tsOops! Something went wrong! :( ESLint: 9.39.3 TypeError: Converting circular structure to JSON src/modules/reverse-proxy/ReverseProxyAccessControlRules.tsxOops! Something went wrong! :( ESLint: 9.39.3 TypeError: Converting circular structure to JSON src/modules/reverse-proxy/ReverseProxyAppSecInspection.tsxOops! Something went wrong! :( ESLint: 9.39.3 TypeError: Converting circular structure to JSON
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
b2b9a5d to
0e98c0e
Compare
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/modules/reverse-proxy/ReverseProxyModal.tsx`:
- Line 817: Update the supportsAppSec prop in ReverseProxyModal to enable AppSec
only when the selected service protocol is HTTP, while preserving the existing
selectedDomain?.supports_appsec capability check for HTTP services.
In `@src/modules/reverse-proxy/table/ReverseProxyAccessControlCell.tsx`:
- Around line 56-58: Update the supportsAppSec lookup in
ReverseProxyAccessControlCell to match the selected service against either the
domain field or target_cluster, so reverseProxy.proxy_cluster values from
ReverseProxyModal resolve the correct capability and preserve the existing
AppSec summary behavior.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 3b824167-cd9b-4776-bde5-26c7b4d524c7
📒 Files selected for processing (8)
src/interfaces/ReverseProxy.tssrc/modules/reverse-proxy/ReverseProxyAccessControlRules.tsxsrc/modules/reverse-proxy/ReverseProxyAppSecInspection.tsxsrc/modules/reverse-proxy/ReverseProxyModal.tsxsrc/modules/reverse-proxy/clusters/ClustersFeaturesCell.tsxsrc/modules/reverse-proxy/events/ReverseProxyEventsAuthMethodCell.tsxsrc/modules/reverse-proxy/events/ReverseProxyEventsReasonCell.tsxsrc/modules/reverse-proxy/table/ReverseProxyAccessControlCell.tsx
0e98c0e to
a0f4a35
Compare
1 participant
Adds the CrowdSec AppSec (WAF) mode selector to reverse proxy access control, alongside the existing IP reputation control. Backend PR: netbirdio/netbird#6917.
Issue ticket number and link
Documentation
Select exactly one:
Docs PR URL (required if "docs added" is checked)
Paste the PR link from https://github.com/netbirdio/docs here:
netbirdio/docs#889
E2E tests
Optional: override the image tags used by the Playwright e2e workflow.
Defaults to
mainwhen omitted.management-cloud-tag: main
reverse-proxy-tag: main
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.Summary by CodeRabbit