Skip to content

doc: add restart policy to Docker NetBird installation - #711

Open
Times-Z wants to merge 2 commits into
netbirdio:mainfrom
Times-Z:feat/missing-restart-policy
Open

doc: add restart policy to Docker NetBird installation#711
Times-Z wants to merge 2 commits into
netbirdio:mainfrom
Times-Z:feat/missing-restart-policy

Conversation

@Times-Z

@Times-Z Times-Z commented Jul 14, 2026

Copy link
Copy Markdown

Hi there

Little documentation improvement for the running command of Docker container for NetBird
I realize with a friend installation that, by default there is no restart policy in the command provided by the helper

Summary by CodeRabbit

  • Improvements
    • Updated the Docker setup command to automatically restart the NetBird container unless it is explicitly stopped.

@CLAassistant

CLAassistant commented Jul 14, 2026

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@coderabbitai

coderabbitai Bot commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

The Docker setup command now includes --restart unless-stopped, preserving the container across host restarts while leaving the existing UI flow unchanged.

Changes

Docker command generation

Layer / File(s) Summary
Add Docker restart policy
src/modules/setup-netbird-modal/DockerTab.tsx
The rendered docker run command now includes the unless-stopped restart policy.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Poem

I’m a bunny hopping by,
With Docker commands reaching high.
unless-stopped keeps things bright,
Containers wake through every night.
Hop, hop—setup’s feeling right!

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (2 warnings)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description is missing the required issue, documentation checkbox, docs PR URL, and E2E test fields from the template. Fill in the template with the issue ticket/link, choose one documentation option, add the docs PR URL if applicable, and include E2E tag values or defaults.
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly matches the change: adding a Docker restart policy to the NetBird installation command.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

ESLint install timed out. The project may have too many dependencies for the sandbox.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@src/modules/setup-netbird-modal/DockerTab.tsx`:
- Around line 62-64: Remove the --rm flag from the Docker command generated in
the DockerTab component, while preserving the existing --restart unless-stopped
option and all other command arguments.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 52d670d8-9238-454e-bf49-4950096d3119

📥 Commits

Reviewing files that changed from the base of the PR and between 377d239 and b61137f.

📒 Files selected for processing (1)
  • src/modules/setup-netbird-modal/DockerTab.tsx

Comment thread src/modules/setup-netbird-modal/DockerTab.tsx Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants