Skip to content

Conversation

@adamoutler
Copy link
Collaborator

@adamoutler adamoutler commented Jan 18, 2026

📌 Description

This PR reworks 2 devcontainer issues.

  1. The order of execution of building test container and initializing services is reversed to allow quicker access to services.
  2. the pamaron.pytest-runner plugin was causing crashes and does not appear to be required.

🔍 Related Issues


📋 Type of Change

  • 🐛 Bug fix
  • ✨ New feature
  • ♻️ Code refactor
  • 📚 Documentation update
  • 🧪 Test addition or change
  • 🔧 Build/config update
  • 🚀 Performance improvement
  • 🔨 CI/CD or automation
  • 🧹 Cleanup / chore

📷 Screenshots or Logs (if applicable)


🧪 Testing Steps

  1. Trigger a devcontainer rebuild.
  2. Observe service availability timing.
  3. Verify VS Code stability without the pamaron.pytest-runner extension.

✅ Checklist

  • I have read the Contribution Guidelines
  • I have tested my changes locally
  • I have updated relevant documentation (if applicable)
  • I have verified my changes do not break existing behavior
  • I am willing to respond to requested changes and feedback

🙋 Additional Notes

The pamaron.pytest-runner extension was identified as the primary source of workspace crashes. Testing confirms that native VS Code Python test discovery handles requirements sufficiently.

Summary by CodeRabbit

  • Chores
    • Optimized development environment configuration and removed unnecessary development extensions to streamline the developer setup process.

Note: This release contains no user-facing changes.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 18, 2026

📝 Walkthrough

Walkthrough

The devcontainer configuration was updated to reorder postStartCommand entries, placing the test-container build before the environment startup, and removed the pytest-runner VSCode extension from the extensions list.

Changes

Cohort / File(s) Summary
Dev Container Configuration
.devcontainer/devcontainer.json
Reordered postStartCommand entries with "Build test-container" now preceding "Start Environment"; added trailing comma to accommodate the reordering; removed pamaron.pytest-runner from vscode extensions list

Poem

🐰 The config hops in new sequence order,
Build before start, let tests soar and explore,
One extension removed from the VSCode store,
Cleaner, faster, who could ask for more!

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title directly addresses the main objectives: removing an extension and optimizing devcontainer performance.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Comment @coderabbitai help to get the list of available commands and usage tips.

@jokob-sk jokob-sk merged commit fd0037e into netalertx:main Jan 18, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants