-
-
Notifications
You must be signed in to change notification settings - Fork 365
Bare metal Installer rework #1173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,7 @@ | ||
| #!/usr/bin/env bash | ||
|
|
||
| echo "---------------------------------------------------------" | ||
| echo "[INSTALL] Run install_dependencies.debian.sh" | ||
| echo "[INSTALL] Run install_dependencies.debian12.sh" | ||
| echo "---------------------------------------------------------" | ||
|
|
||
| # ❗ IMPORTANT - if you modify this file modify the root Dockerfile as well ❗ | ||
|
|
@@ -23,12 +23,11 @@ sudo apt-get install nginx nginx-core mtr php-fpm php8.2-fpm php-cli php8.2 php8 | |
| sudo phpenmod -v 8.2 sqlite3 | ||
|
|
||
| # setup virtual python environment so we can use pip3 to install packages | ||
| apt-get install python3.11-venv -y | ||
| apt-get install python3-venv -y | ||
| python3 -m venv myenv | ||
| source myenv/bin/activate | ||
|
|
||
|
Comment on lines
25
to
29
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🛠️ Refactor suggestion Virtualenv created in an indeterminate directory. Because this script can be invoked from anywhere, creating “myenv” in CWD is brittle. Create and activate the venv relative to the script’s own directory. -# setup virtual python environment so we can use pip3 to install packages
-apt-get install python3-venv -y
-python3 -m venv myenv
-source myenv/bin/activate
+# setup virtual python environment so we can use pip3 to install packages
+apt-get install -y python3-venv
+SCRIPT_DIR="$(cd -- "$(dirname -- "${BASH_SOURCE[0]}")" >/dev/null 2>&1 && pwd)"
+python3 -m venv "${SCRIPT_DIR}/.venv"
+source "${SCRIPT_DIR}/.venv/bin/activate"
🤖 Prompt for AI Agents |
||
| update-alternatives --install /usr/bin/python python /usr/bin/python3 10 | ||
|
|
||
| # install packages thru pip3 | ||
| pip3 install openwrt-luci-rpc asusrouter asyncio aiohttp graphene flask flask-cors unifi-sm-api tplink-omada-client wakeonlan pycryptodome requests paho-mqtt scapy cron-converter pytz json2table dhcp-leases pyunifi speedtest-cli chardet python-nmap dnspython librouteros yattag git+https://github.com/foreign-sub/aiofreepybox.git | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix wording and markdownlint issues in the WARNING block.
Correct typo and remove blank line/multiple spaces after blockquote symbols to satisfy MD027/MD028.
📝 Committable suggestion
🤖 Prompt for AI Agents