Changing absolute path URL to relative path URL in report.php #1140
Conversation
Change static route to relative route in URL for proper proxy operation
WalkthroughChanged the fetch URL in front/report.php’s updateData from an absolute path (/php/...) to a relative path (php/...). No other logic or public/exported entities were modified. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
actor User as Browser
participant ReportJS as front/report.php (client)
participant Server as php/server/query_json.php
Note over ReportJS: updateData()
User->>ReportJS: Trigger update
ReportJS->>Server: fetch("php/server/query_json.php?file=table_notifications.json&nocache=...") <!-- relative path -->
Server-->>ReportJS: JSON notifications
ReportJS-->>User: Render updated table
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
Tip 🔌 Remote MCP (Model Context Protocol) integration is now available!Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats. ✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
front/report.php (2)
153-174: Keep both fetches consistent (cache-busting and URL construction)There’s a second fetch to the same endpoint without the “nocache” param. For consistency and to avoid stale responses under some proxies/CDNs, consider adding cache-busting here as well and centralizing URL building (e.g., via a small helper that respects document.baseURI).
Example:
function notificationsUrl(params = {}) { const url = new URL('php/server/query_json.php', document.baseURI); url.searchParams.set('file', 'table_notifications.json'); if (params.nocache !== false) url.searchParams.set('nocache', Date.now().toString()); return url.toString(); } // usage fetch(notificationsUrl()); // with nocache // ... fetch(notificationsUrl({ nocache: false })); // if you explicitly want caching
90-126: Add response.ok check to fail fast on HTTP errorsCurrently errors like 404/500 will flow into response.json() and throw less clear exceptions. A quick guard improves diagnosability:
.then(response => { if (!response.ok) throw new Error(`HTTP ${response.status} fetching notifications`); return response.json(); })
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (1)
front/report.php(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: docker_dev
🔇 Additional comments (1)
front/report.php (1)
89-89: Relative fetch URL is validWe confirmed that
front/php/server/query_json.phpexists and there is no<base href>in anyheader.php. Callingfetch(`php/server/query_json.php?file=table_notifications.json&nocache=${Date.now()}`)from
/front/report.phpcorrectly resolves to/front/php/server/query_json.php. No path change is required.
|
Thanks @cvc90 ! |
2 participants
Hi @jokob-sk,
Pull Request
Description
Changed the absolute path URL to relative path URL in report.php, this is a fix for issues with reverse proxy servers.
Changes
Update report.php (/front/report.php)
URLs were changed from absolute paths to relative paths
Test
Tested locally and works fine
Change static route to relative route in URL for proper proxy operation
Summary by CodeRabbit