Skip to content
This repository was archived by the owner on Feb 12, 2023. It is now read-only.

Conversation

@helto4real
Copy link
Collaborator

Breaking change

Proposed change

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the [development checklist][dev-checklist]
  • The code compiles without warnings (code quality chek)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@codecov-commenter
Copy link

Codecov Report

Base: 62.57% // Head: 62.50% // Decreases project coverage by -0.06% ⚠️

Coverage data is based on head (78c03b8) compared to base (2a05600).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev      #94      +/-   ##
==========================================
- Coverage   62.57%   62.50%   -0.07%     
==========================================
  Files         179      179              
  Lines        6667     6668       +1     
  Branches      927      927              
==========================================
- Hits         4172     4168       -4     
- Misses       2159     2163       +4     
- Partials      336      337       +1     
Flag Coverage Δ
unittests 62.50% <0.00%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...unner/Infrastructure/Config/SerilogConfigurator.cs 0.00% <ø> (ø)
...DaemonRunner/DaemonRunner/Service/RunnerService.cs 0.00% <0.00%> (ø)
...pp/NetDaemon.App/Common/Reactive/NetDaemonRxApp.cs 82.20% <0.00%> (-1.70%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 3725577915

  • 0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
  • 5 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.05%) to 63.127%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/DaemonRunner/DaemonRunner/Service/RunnerService.cs 0 1 0.0%
Files with Coverage Reduction New Missed Lines %
src/DaemonRunner/DaemonRunner/Infrastructure/Config/SerilogConfigurator.cs 1 0%
src/DaemonRunner/DaemonRunner/Service/RunnerService.cs 1 0%
src/App/NetDaemon.App/Common/Reactive/NetDaemonRxApp.cs 3 85.44%
Totals Coverage Status
Change from base Build 3385270854: -0.05%
Covered Lines: 4501
Relevant Lines: 6667

💛 - Coveralls

@helto4real helto4real merged commit e44445f into dev Dec 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants