Skip to content
This repository was archived by the owner on Feb 12, 2023. It is now read-only.

Conversation

@helto4real
Copy link
Collaborator

@helto4real helto4real commented Jan 18, 2022

Breaking change

Proposed change

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the [development checklist][dev-checklist]
  • The code compiles without warnings (code quality chek)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@coveralls
Copy link

Pull Request Test Coverage Report for Build 1713645137

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 4 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.09%) to 63.074%

Files with Coverage Reduction New Missed Lines %
src/Daemon/NetDaemon.Daemon/Daemon/NetDaemonHost.cs 1 60.26%
src/App/NetDaemon.App/Common/Reactive/NetDaemonRxApp.cs 3 85.44%
Totals Coverage Status
Change from base Build 1689541729: -0.09%
Covered Lines: 4501
Relevant Lines: 6666

💛 - Coveralls

@helto4real helto4real merged commit 96390b4 into dev Jan 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants