Skip to content
This repository was archived by the owner on Feb 12, 2023. It is now read-only.

Conversation

@helto4real
Copy link
Collaborator

@helto4real helto4real commented Apr 9, 2022

Breaking change

Proposed change

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the [development checklist][dev-checklist]
  • The code compiles without warnings (code quality chek)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@codecov-commenter
Copy link

Codecov Report

Merging #29 (6b0bd3a) into dev (7ef8f39) will increase coverage by 0.04%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##              dev      #29      +/-   ##
==========================================
+ Coverage   62.53%   62.57%   +0.04%     
==========================================
  Files         179      179              
  Lines        6667     6667              
  Branches      927      927              
==========================================
+ Hits         4169     4172       +3     
+ Misses       2162     2159       -3     
  Partials      336      336              
Flag Coverage Δ
unittests 62.57% <ø> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
....App/Common/Reactive/ObservableExtensionMethods.cs 65.21% <0.00%> (+13.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ef8f39...6b0bd3a. Read the comment docs.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 2140848069

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.03%) to 63.186%

Totals Coverage Status
Change from base Build 1967472729: 0.03%
Covered Lines: 4504
Relevant Lines: 6666

💛 - Coveralls

@helto4real helto4real merged commit 70567c0 into dev Apr 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants