Fix bug in shiftfs checker. #60
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's a bug in the shiftfs checker that is causing it report false negatives (i.e., it believes shiftfs is not working in hosts where it actually is working). The bug was that shiftfs checker was creating a test dir where shiftfs will be mounted, and chowning that dir to the user-ns mapped uid:gid. However that dir must not be chowned, since the shiftfs mount on it already ensures that root in the user-ns will be able to access it. In fact by chowning it we are causing shiftfs to not work properly on it. Signed-off-by: Cesar Talledo <cesar.talledo@docker.com>
This was referenced May 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a bug in the shiftfs checker that is causing it report false negatives (i.e., it believes shiftfs is not working in hosts where it actually is working).
The bug was that shiftfs checker was creating a test dir where shiftfs will be mounted, and chowning that dir to the user-ns mapped uid:gid. However that dir must not be chowned, since the shiftfs mount on it already ensures that root in the user-ns will be able to access it. In fact by chowning it we are causing shiftfs to not work properly on it.
Fixes nestybox/sysbox#922.