Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add soft delete option #582

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Schubidu
Copy link

@Schubidu Schubidu commented Jul 29, 2020

I add feature for TypeOrm to make soft-delete, relates to #433

@eugenio165
Copy link
Contributor

There is an issue (#523) related to raising the typeorm version, for this to be merged that bug also needs to be solved, if it is in fact a problem with this package. I'll try to take a closer look to help out, nice PR!

@@ -14,7 +14,7 @@ export interface RoutesOptions {

export interface BaseRouteOptions {
interceptors?: any[];
decorators?: (PropertyDecorator | MethodDecorator)[];
decorators?: Array<PropertyDecorator | MethodDecorator>;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quick question... is there a functional difference here, or is this just syntax? Shouldn't those two lines do the same thing?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just syntax. My IDE changed that automatically.

@ruslanguns
Copy link

I think this should be campaign with the restore and recover methods.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants